Add change feed properties to 2019-04-01 Storage. #7049

tonykjose · 2019-08-27T20:24:31Z

Add change feed properties to Storage Blob Services.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Add change feed properties to Storage Blob Services.

openapi-sdkautomation · 2019-08-27T20:24:34Z

In Testing, Please Ignore

[Logs] (Generated from 7743674, Iteration 2)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Storage [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.Storage.4.2.0-preview.nupkg
- Microsoft.Azure.Management.Storage.4.2.0-preview.symbols.nupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-storage [Logs] [Instructions] [Generation PR]
- azure-mgmt-storage-4.0.0.zip
- azure_mgmt_storage-4.0.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

storage/resource-manager/v2016_01_01 [Logs] [Instructions] [Generation PR]
storage/resource-manager/v2017_10_01 [Logs]
storage/resource-manager/v2018_02_01 [Logs]
storage/resource-manager/v2018_03_01_preview [Logs]
storage/resource-manager/v2018_07_01 [Logs]
storage/resource-manager/v2019_04_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/storage/mgmt/2015-05-01-preview [Logs]
preview/storage/mgmt/2018-03-01-preview [Logs]
storage/mgmt/2015-06-15 [Logs]
storage/mgmt/2016-01-01 [Logs]
storage/mgmt/2016-05-01 [Logs]
storage/mgmt/2016-12-01 [Logs]
storage/mgmt/2017-06-01 [Logs]
storage/mgmt/2017-10-01 [Logs]
storage/mgmt/2018-02-01 [Logs]
storage/mgmt/2018-07-01 [Logs]
storage/mgmt/2018-11-01 [Logs]
storage/mgmt/2019-04-01 [Logs] [Instructions] [Generation PR] [Integration PR]
- storage.mgmt.2019-04-01.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-storage [Logs] [Instructions] [Generation PR]
- azure-arm-storage-9.0.1.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]

No packages generated.

AutorestCI · 2019-08-27T20:26:35Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6885

azuresdkci · 2019-08-27T20:44:47Z

Can one of the admins verify this patch?

AutorestCI · 2019-08-27T21:02:15Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5707

weidongxu-microsoft · 2019-08-28T01:13:10Z

Is this a readonly property, or not?

If not, it might break GET-PUT pipeline. https://microsoft.sharepoint.com/:w:/t/azureresourcemanagerteam/EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw?rtime=oPAFQY8Z10g

tonykjose · 2019-08-28T02:08:59Z

It is not a read-only property. Having said this, unless the customer explicitly disables the property by explicitly setting the property to false, our PUT semantics will ignore the update on the property. This is consistent with all Storage APIs i.e. PUT as update = PATCH and not a full resource replace.

…

-Tony From: Weidong Xu <notifications@github.com> Sent: Tuesday, August 27, 2019 6:14 PM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Anthony Kunnel Jose <Anthony.Kunnel@microsoft.com>; Author <author@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Add change feed properties to 2019-04-01 Storage. (#7049) Is this a readonly property, or not? If not, it might break GET-PUT pipeline. https://microsoft.sharepoint.com/:w:/t/azureresourcemanagerteam/EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw?rtime=oPAFQY8Z10g<https://nam06.safelinks.protection.outlook.com/ap/w-59584e83/?url=https%3A%2F%2Fmicrosoft.sharepoint.com%2F%3Aw%3A%2Ft%2Fazureresourcemanagerteam%2FEWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw%3Frtime%3DoPAFQY8Z10g&data=02%7C01%7CAnthony.Kunnel%40microsoft.com%7C608bfa4724d14a3fe8cb08d72b54f7bf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637025516241815277&sdata=rSnhlttvQ3Ah0ZMc7PVtWxJY21G8CjxmS7sVZn%2BdY9c%3D&reserved=0> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7049%3Femail_source%3Dnotifications%26email_token%3DAFJW7YAUDUG3X3HJFPN5HPDQGXGMNA5CNFSM4IQMCRQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JSKOI%23issuecomment-525542713&data=02%7C01%7CAnthony.Kunnel%40microsoft.com%7C608bfa4724d14a3fe8cb08d72b54f7bf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637025516241815277&sdata=F%2FGG0yjjpIejxpnAQVVJWhdl6NhkIjIvM9I8PCgvJeM%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFJW7YG2GWPFRF5IXNEL42LQGXGMNANCNFSM4IQMCRQQ&data=02%7C01%7CAnthony.Kunnel%40microsoft.com%7C608bfa4724d14a3fe8cb08d72b54f7bf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637025516241825266&sdata=mZVdiXN3HmplVw8ohs4%2B%2B9Etx1cyB51Nf7NMj7HWj0c%3D&reserved=0>.

weidongxu-microsoft · 2019-08-28T02:15:09Z

@tonykjose So if user1 with latest SDK call PUT and set the property to false, and then user2 with old SDK call GET, change some other property, then PUT without this property, it will stay false. Then I think it should be fine.

I think I still need ARM signoff.

tonykjose · 2019-08-28T05:25:08Z

Yes that is correct.

…

-Tony

________________________________ From: Weidong Xu <notifications@github.com> Sent: Tuesday, August 27, 2019 7:15:36 PM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Anthony Kunnel Jose <Anthony.Kunnel@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Add change feed properties to 2019-04-01 Storage. (#7049) @tonykjose<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftonykjose&data=02%7C01%7CAnthony.Kunnel%40microsoft.com%7C4123986b31e94692412108d72b5d9dad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637025553393715963&sdata=%2BhMMY0CcKXjh4gIhUeWuyvj2CGNnhwIWY0uVtIBWHwg%3D&reserved=0> So if user1 with latest SDK call PUT and set the property to false, and then user2 with old SDK call GET, change some other property, then PUT without this property, it will stay false. Then I think it should be fine. I think I still need ARM signoff. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7049%3Femail_source%3Dnotifications%26email_token%3DAFJW7YF5EBTIDDTXYFBSCD3QGXNURA5CNFSM4IQMCRQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JVI5I%23issuecomment-525554805&data=02%7C01%7CAnthony.Kunnel%40microsoft.com%7C4123986b31e94692412108d72b5d9dad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637025553393715963&sdata=lbwWYv9d0Q5khw9foW6sFcdznKgVOtcoVbZYj%2Bk%2F%2B78%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFJW7YAPMAUMGPNZ4I2XJGDQGXNURANCNFSM4IQMCRQQ&data=02%7C01%7CAnthony.Kunnel%40microsoft.com%7C4123986b31e94692412108d72b5d9dad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637025553393725963&sdata=l27qA5PYwhgTR59oZbWqUjfAKIj5xjkzSpj%2BBcyqyHQ%3D&reserved=0>.

KrisBash

Please see one comment, but signing off

KrisBash · 2019-09-06T02:07:08Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/blob.json

+    "ChangeFeed": {
+      "properties": {
+        "enabled": {
+          "type": "boolean",


booleans are less preferred as it becomes a breaking change if you need to change to an enum later. If you model this as something like '"state":[enabled|disabled]' you can add tertiary states to the enum later, without a breaking change. Something to consider.

weidongxu-microsoft · 2019-09-06T03:04:55Z

/AzurePipelines run

azure-pipelines · 2019-09-06T03:05:10Z

Azure Pipelines successfully started running 2 pipeline(s).

Add change feed properties to 2019-04-01 Storage.

7743674

Add change feed properties to Storage Blob Services.

azuresdkci assigned weidongxu-microsoft Aug 27, 2019

azuresdkci requested a review from weidongxu-microsoft August 27, 2019 20:25

AutorestCI mentioned this pull request Aug 27, 2019

[AutoPR storage/resource-manager] Add change feed properties to 2019-04-01 Storage. Azure/azure-sdk-for-python#6956

Merged

AutorestCI mentioned this pull request Aug 27, 2019

[AutoPR storage/resource-manager] Add change feed properties to 2019-04-01 Storage. Azure/azure-sdk-for-go#5621

Merged

weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 28, 2019

KrisBash approved these changes Sep 6, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2019

weidongxu-microsoft approved these changes Sep 6, 2019

View reviewed changes

weidongxu-microsoft merged commit 35ae8d5 into Azure:master Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add change feed properties to 2019-04-01 Storage. #7049

Add change feed properties to 2019-04-01 Storage. #7049

tonykjose commented Aug 27, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2019 •

edited

Loading

AutorestCI commented Aug 27, 2019 •

edited

Loading

azuresdkci commented Aug 27, 2019

AutorestCI commented Aug 27, 2019 •

edited

Loading

weidongxu-microsoft commented Aug 28, 2019

tonykjose commented Aug 28, 2019 via email

weidongxu-microsoft commented Aug 28, 2019

tonykjose commented Aug 28, 2019 via email

KrisBash left a comment

KrisBash Sep 6, 2019

weidongxu-microsoft commented Sep 6, 2019

azure-pipelines bot commented Sep 6, 2019

Add change feed properties to 2019-04-01 Storage. #7049

Add change feed properties to 2019-04-01 Storage. #7049

Conversation

tonykjose commented Aug 27, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Aug 27, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 7743674, Iteration 2)

AutorestCI commented Aug 27, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 27, 2019

AutorestCI commented Aug 27, 2019 • edited Loading

Automation for azure-sdk-for-go

weidongxu-microsoft commented Aug 28, 2019

tonykjose commented Aug 28, 2019 via email

weidongxu-microsoft commented Aug 28, 2019

tonykjose commented Aug 28, 2019 via email

KrisBash left a comment

Choose a reason for hiding this comment

KrisBash Sep 6, 2019

Choose a reason for hiding this comment

weidongxu-microsoft commented Sep 6, 2019

azure-pipelines bot commented Sep 6, 2019

tonykjose commented Aug 27, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2019 •

edited

Loading

AutorestCI commented Aug 27, 2019 •

edited

Loading

AutorestCI commented Aug 27, 2019 •

edited

Loading